Itc basis updates#1395
Open
brtietz wants to merge 19 commits into
Open
Conversation
5 tasks
Coverage Report for CI Build 26111458724Coverage increased (+0.06%) to 56.347%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions1488 previously-covered lines in 12 files lost coverage.
Coverage Stats
💛 - Coveralls |
…leaseback is different
…itc_basis_updates
…oke in the process
…n_cmod_pvsamv1.LCOS_test_cashloan still failing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Add code to common financial to handle new ITC basis input options. A few variables that previously held bools now function as 0-1 fractions.
Corresponding branches and PRs:
SAM branch itc_basis_updates NatLabRockies/SAM#2187
develop for other branches
Unit Test Impact:
New tests written for common financial functions.
Existing tests using the old manual paradigm should remain unchanged.
Checklist